Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor reactions / hand raised to use rxjs and start ordering tiles based on hand raised. #2885

Draft
wants to merge 12 commits into
base: livekit
Choose a base branch
from
Draft

Refactor reactions / hand raised to use rxjs and start ordering tiles based on hand raised. #2885

wants to merge 12 commits into from

Conversation

Half-Shot
Copy link
Member

Fixes #2715
Fixes #2843

This change will adjust our code so that consumers of reactions and hand raised state use the CallViewModel as much as possible, which allows us to finally do fun stuff like order tiles by hand raised

This is getting close to working, I think this just needs tests to be adjusted.

@Half-Shot Half-Shot mentioned this pull request Dec 9, 2024
Closed
@Half-Shot Half-Shot changed the title Refactor redactions / hand raised to use rxjs and start ordering tiles based on hand raised. Refactor reactions / hand raised to use rxjs and start ordering tiles based on hand raised. Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Half-Shot